Bug Peak_n_valley Indikator

[leenazen]

Not working the peak based Please help me need working

 

[billbroch]

It's still not bad though. Had you just taken the trades in the picture you would have won 4 of 5 trades. Using the previous swing high/low each trade could have made 3:1. That is a good return rate.

How is the Peak being calculated now?

 

[garago]

Try tihis.
I take this opportunity to thank leenazen his work.
Ciao

 

[leenazen]

Thanks bro are you coder?

 

[billbroch]

Thanks bro are you coder?

Leenazen,

Did the version that garago shared work the way you wanted? What's the change?

 

[billbroch]

This is my review for this thread:
Good indicator and quick response from coder

 

[leenazen]

I'm not coder please contact coder!!!!!!!

 

[garago]

Yes, I'm a coder, but a busy daddy with few time

 

[leenazen]

Now 7 bar delay as come to the signal's would you change the current bar will appear the signal with no repaint also need

 

[garago]

Now 7 bar delay as come to the signal's would you change the current bar will appear the signal with no repaint also need

Ciao
The indicator works on iHigh (i)> iHighest (i + 1)
my opinion is that it does not repaint because it has a delay of 7 (Period/3)
I have insert extern input FastShift=7;
If we try to put a delay of 1, would have the same problems as the ZIGZAG

forgive my terrible English

 

[billbroch]

I like this indicator but it's making my MT4 chart run extremely slow... am I missing something?

 

[billbroch]

I like this indicator but it's making my MT4 chart run extremely slow... am I missing something?

I see now. It was a script before on MQL5 and you're making it an indicator If you get this without a delay in it, it would be a good indicator.... very good!

 

[Adam53]

2018.03.02 20:40:56.060 EURUSD,H1: indicator(s) working too slowly, total calculation time 2871 ms

 

[blackking]

Look like good indicator with looking for signal on peak or bottom of pattern bar
might help much for manual trader if signal appear for confirmation entry

 

[NeoBatavia]

Why don't you just use Zigzag indi. Same function different graphic.

 

[Dexterous]

The indicator lags, be careful

 

[billbroch]

2018.03.02 20:40:56.060 EURUSD,H1: indicator(s) working too slowly, total calculation time 2871 ms

This indicator was a script and was converted to an indicator. The problem is that it is drawing each dot as an object on your chart. So it is constantly drawing back thousands of dots. It would probably work better if someone could change the code to not draw each dot as an object and to only draw maybe 1000 bars back.

 

[garago]

Why don't you just use Zigzag indi. Same function different graphic.

I agree.
Ciao

 

[garago]

Leenazen,
Did the version that garago shared work the way you wanted? What's the change?

I'm sorry, I can see your question now. I have not changed anything in logic. I just turned the script from EA to Indicator.
Ciao

 

[billbroch]

I'm sorry, I can see your question now. I have not changed anything in logic. I just turned the script from EA to Indicator.
Ciao

Thanks for the info, too bad it's just another indicator that looks great in the history but can't paint in real time the same way