1. Welcome back! Thank you for being a part of this Traders Community. Let's discuss and share :)
    Selamat datang kembali! Trimakasih telah menjadi bagian dari Komunitas Trader ini. Mari berdiskusi dan berbagi :)
    Dismiss Notice

Bug Peak_n_valley Indikator

Discussion in 'Indicators dan Tools' started by leenazen, 02 Mar 2018.

  1. leenazen

    leenazen Active Member Credit Hunter

    Equity
    Credit
    Ref Point
    [​IMG]


    Not working the peak based Please help me need working
     

    Attached Files:

    • Like Like x 2
    • Dislike Dislike x 1
  2. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    It's still not bad though. Had you just taken the trades in the picture you would have won 4 of 5 trades. Using the previous swing high/low each trade could have made 3:1. That is a good return rate.

    How is the Peak being calculated now?
     
  3. garago

    garago Member Credit Hunter

    Equity
    Credit
    Ref Point
    Try tihis.
    I take this opportunity to thank leenazen his work.
    Ciao
     

    Attached Files:

    • Dislike Dislike x 1
  4. leenazen

    leenazen Active Member Credit Hunter

    Equity
    Credit
    Ref Point
    Thanks bro are you coder?
     
  5. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    Leenazen,

    Did the version that garago shared work the way you wanted? What's the change?
     
  6. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    4/5,
    This is my review for this thread:
    Good indicator and quick response from coder
     
  7. leenazen

    leenazen Active Member Credit Hunter

    Equity
    Credit
    Ref Point
    I'm not coder please contact coder!!!!!!!
     
  8. garago

    garago Member Credit Hunter

    Equity
    Credit
    Ref Point
    Yes, I'm a coder, but a busy daddy with few time :D
     
  9. leenazen

    leenazen Active Member Credit Hunter

    Equity
    Credit
    Ref Point
    Now 7 bar delay as come to the signal's would you change the current bar will appear the signal with no repaint also need
     
  10. garago

    garago Member Credit Hunter

    Equity
    Credit
    Ref Point
    Ciao
    The indicator works on iHigh (i)> iHighest (i + 1)
    my opinion is that it does not repaint because it has a delay of 7 (Period/3)
    I have insert extern input FastShift=7;
    If we try to put a delay of 1, would have the same problems as the ZIGZAG

    forgive my terrible English
     

    Attached Files:

    • Like Like x 1
  11. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    I like this indicator but it's making my MT4 chart run extremely slow... am I missing something?
     
  12. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    I see now. It was a script before on MQL5 and you're making it an indicator ;) If you get this without a delay in it, it would be a good indicator.... very good!
     
  13. Adam53

    Adam53 Member Credit Hunter

    Equity
    Credit
    Ref Point
    2018.03.02 20:40:56.060 EURUSD,H1: indicator(s) working too slowly, total calculation time 2871 ms
     
    • Agree Agree x 1
  14. blackking

    blackking Well-Known Member Credit Hunter

    Equity
    Credit
    Ref Point
    Look like good indicator with looking for signal on peak or bottom of pattern bar
    might help much for manual trader if signal appear for confirmation entry
     
  15. NeoBatavia

    NeoBatavia Well-Known Member Credit Hunter

    Equity
    Credit
    Ref Point
    Why don't you just use Zigzag indi. Same function different graphic.
     
  16. Dexterous

    Dexterous Member Credit Hunter

    Equity
    Credit
    Ref Point
    The indicator lags, be careful
     
  17. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    This indicator was a script and was converted to an indicator. The problem is that it is drawing each dot as an object on your chart. So it is constantly drawing back thousands of dots. It would probably work better if someone could change the code to not draw each dot as an object and to only draw maybe 1000 bars back.
     
  18. garago

    garago Member Credit Hunter

    Equity
    Credit
    Ref Point
    I agree.
    Ciao
     
  19. garago

    garago Member Credit Hunter

    Equity
    Credit
    Ref Point
    I'm sorry, I can see your question now. I have not changed anything in logic. I just turned the script from EA to Indicator.
    Ciao
     
    • Like Like x 1
  20. billbroch

    billbroch Member Credit Hunter

    Equity
    Credit
    Ref Point
    Thanks for the info, too bad it's just another indicator that looks great in the history but can't paint in real time the same way :p
     

Share This Page